Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade to .yml based issue-templates #2278

Merged
merged 11 commits into from
Sep 17, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Sep 11, 2024

What I did

  • Upgrades to .yml based issue templates
  • Offers bigger section for reproduction steps

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

Copy link
Contributor

@bitwise-constructs bitwise-constructs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to make the template yml

@antazoey
Copy link
Member Author

im gonna convert the others too

fubuloubu
fubuloubu previously approved these changes Sep 11, 2024
@fubuloubu
Copy link
Member

fubuloubu commented Sep 11, 2024

im gonna convert the others too

I wonder if github has a way to make this org-level instead of each repo

@antazoey antazoey changed the title docs: make easier to provider reproduction steps docs: upgrade to .yml based tempaltes Sep 11, 2024
@antazoey antazoey changed the title docs: upgrade to .yml based tempaltes docs: upgrade to .yml based issue-templates Sep 11, 2024
@antazoey
Copy link
Member Author

I wonder if github has a way to make this org-level instead of each repo

there are some differences though, like eip712 doesn't care about your ape-config file or ape plugins, etc.
and ape-vyper may wonder about your vyper version + syntax

@antazoey
Copy link
Member Author

antazoey commented Sep 11, 2024

i just wish i can view / demo these before merging

Edit: OK I can on my fork / branch when viewing the files, so doing that now

@antazoey antazoey force-pushed the docs/ask-for-repro branch 8 times, most recently from c4738b5 to cb891ed Compare September 11, 2024 18:27
@fubuloubu
Copy link
Member

I wonder if github has a way to make this org-level instead of each repo

there are some differences though, like eip712 doesn't care about your ape-config file or ape plugins, etc. and ape-vyper may wonder about your vyper version + syntax

yeah exactly, set an org-level, and then set specific ones for repos that don't match

@fubuloubu
Copy link
Member

im gonna convert the others too

I wonder if github has a way to make this org-level instead of each repo

yes there is!
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file#supported-file-types

@antazoey
Copy link
Member Author

antazoey commented Sep 16, 2024

yes there is! https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file#supported-file-types

OK, I followed those instructions and created https://github.com/ApeWorX/.github
Then, I removed any file here that was un-altered, FUNDING.yml, PULL_REQUEST_TEMPLATE.yml, and SECURITY.md guide, as all of those files are supported in the community repo thing

@fubuloubu
Copy link
Member

This gave me some other ideas for the .github repo

@fubuloubu
Copy link
Member

ApeWorX/.github#1

@antazoey antazoey merged commit c50bee9 into ApeWorX:main Sep 17, 2024
16 checks passed
@antazoey antazoey deleted the docs/ask-for-repro branch September 17, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants